Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload signature alongside snapshots artifacts and checksums #561

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Nov 6, 2024

Description

Upload signature alongside snapshots artifacts and checksums

Issues Resolved

opensearch-project/opensearch-build#5096

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (ac5825d) to head (89679b5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #561   +/-   ##
=========================================
  Coverage     84.75%   84.75%           
  Complexity      114      114           
=========================================
  Files           117      117           
  Lines           682      682           
  Branches         75       75           
=========================================
  Hits            578      578           
  Misses           30       30           
  Partials         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. @peterzhuamazon

@peterzhuamazon peterzhuamazon merged commit 0196bcb into opensearch-project:main Nov 7, 2024
9 checks passed
@peterzhuamazon peterzhuamazon deleted the snapshots-signing-libs branch November 7, 2024 22:35
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 0196bcb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 7.x enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants