Add binary index support for Lucene engine #2292
Open
+260
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jed326
force-pushed
the
binary-vector-lucene
branch
from
efdd815
to
625fd1c
Compare
jed326
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
jed326
force-pushed
the
binary-vector-lucene
branch
from
625fd1c
to
882a672
Compare
|
@heemin32 @navneet1v @jmazanec15 could you please help review? Also it looks like the linux build is broken. |
Signed-off-by: Jay Deng <jayd0104@gmail.com>
jed326
force-pushed
the
binary-vector-lucene
branch
from
882a672
to
0ab5494
Compare
|
@peterzhuamazon are there changes in the CI image? we are seeing failures due to GlibC |
Hi @navneet1v you can follow the guide here to mitigate the issue: Please let me know if you have more questions, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add binary vector support for Lucene engine. For testing I parameterized
BinaryIndexIT.javato run with bothFAISSandLUCENEengines.Related Issues
Resolves #1857
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.