Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle upgrade to 8.10.2, run CI checks with JDK 23 #688

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Gradle upgrade to 8.10.2, run CI checks with JDK 23 #688

merged 1 commit into from
Oct 15, 2024

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Oct 15, 2024 •
edited
Loading

Description

Gradle upgrade to 8.10.2

Related Issues

Part of #687

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi
Gradle upgrade to 8.10.2
97e9c6d 
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
@prudhvigodithi prudhvigodithi self-assigned this Oct 15, 2024
@prudhvigodithi
Copy link
Member Author

Adding @reta @cwperks @peterzhuamazon to please take a look, this PR should unblock the 3.0.0 builds. Part of #687
Thanks
@getsaurabh02

reta
reta approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prudhvigodithi !

gaiksaya
gaiksaya approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add support for JDK-23 in PR title and description?
Thanks!

@cwperks cwperks changed the title Gradle upgrade to 8.10.2 Gradle upgrade to 8.10.2, run CI checks with JDK 23 Oct 15, 2024
@cwperks cwperks merged commit 31227ad into opensearch-project:main Oct 15, 2024
11 checks passed
@reta reta mentioned this pull request Oct 15, 2024
Merged
5 tasks
cwperks pushed a commit that referenced this pull request Oct 15, 2024
@reta @prudhvigodithi
Gradle upgrade to 8.10.2 (#688) (#689)
5d877e4 
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaiksaya gaiksaya gaiksaya approved these changes

@cwperks cwperks cwperks approved these changes

@reta reta reta approved these changes

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

@vibrantvarun vibrantvarun Awaiting requested review from vibrantvarun vibrantvarun is a code owner

Assignees

@prudhvigodithi prudhvigodithi

Labels
None yet
Projects
Engineering Effectiveness Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prudhvigodithi @reta @cwperks @gaiksaya