Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci version parsing script #662

Closed

Conversation

finnegancarroll
Copy link
Collaborator

@finnegancarroll finnegancarroll commented Nov 4, 2024

Description

This build.yml script is slightly off due to the extra '-' in "asynchronous-search".
Current output:

plugin version plugin_version qualifier docker_version
(opensearch-asynchronous-search-3.0.0.0-SNAPSHOT.zip) (search) (search) (-3) (search-3)
/home/runner/work/asynchronous-search/asynchronous-search
-rw-r--r-- 1 runner docker 980985 Nov  4 20:14 ./opensearch-asynchronous-search-3.0.0.0-SNAPSHOT.zip
Error response from daemon: manifest for opensearchstaging/opensearch:search-3 not found: manifest unknown: manifest unknown

Off by one error fixed:

plugin=opensearch-asynchronous-search-3.0.0.0-SNAPSHOT.zip
version=`echo $plugin|awk -F- '{print $4}'| cut -d. -f 1-3`
plugin_version=`echo $plugin|awk -F- '{print $4}'| cut -d. -f 1-4`
qualifier=`echo $plugin|awk -F- '{print $5}'| cut -d. -f 1-1`
echo $version
3.0.0
echo $plugin_version
3.0.0.0
echo $qualifier
SNAPSHOT

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Finn Carroll <carrofin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant