-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating setup-java, byte buddy, jacoco and mockito dependencies #1368
Updating setup-java, byte buddy, jacoco and mockito dependencies #1368
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
============================================
- Coverage 80.07% 80.01% -0.07%
+ Complexity 5672 5666 -6
============================================
Files 533 533
Lines 23438 23438
Branches 2334 2334
============================================
- Hits 18769 18753 -16
- Misses 3560 3575 +15
- Partials 1109 1110 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
2207a1c
to
1b6cb6e
Compare
.github/workflows/maven-publish.yml
Outdated
@@ -28,7 +28,7 @@ jobs: | |||
distribution: temurin # Temurin is a distribution of adoptium | |||
java-version: 21 | |||
- uses: actions/checkout@v4 | |||
- uses: aws-actions/configure-aws-credentials@v4.0.1 | |||
- uses: aws-actions/configure-aws-credentials@v4.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest just use v4
instead of specific version unless you have specific requirements here.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We keep getting depandabot PRs for this, do you know why we are getting this and other repos aren't? #1182
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use v4 it will automatically link to the latest v4.x.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
The above can be completely removed as github already deprecate this params.
1b6cb6e
to
a1d1407
Compare
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
a1d1407
to
71418d0
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.x
# Create a new branch
git switch --create backport/backport-1368-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cad961074760baaf31e984055b3a57d83a25d7e3
# Push it to GitHub
git push --set-upstream origin backport/backport-1368-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.x Then, create a pull request where the |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Description
Updating several different dependencies that we have outdated depandabot PRs for.
Also testing out this solution for some of our workflows that still have checkout@v3.
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.