added test for map variables #40
Conversation
| @@ -647,3 +647,30 @@ GET /test | |||
| nil | |||
| --- no_error_log | |||
| [error] | |||
|
|
|||
| === TEST 19: upstream_name with valid explicit upstream set by variable | |||
There was a problem hiding this comment.
What's the point of this test case? Testing the standard map directive?
There was a problem hiding this comment.
Point is to test situation where current_upstream_name() is called with block of upstream set by variable. For example, current_upstream_name() works fine in issue
#39 when scheme is explicitly set (location: /test). And returns error when scheme is set via variable (location: /test2).
|
@amgorb The Travis CI testing is failing. Are you reporting a bug or just enriching the test suite? Please always be explicit. |
|
@agentzh Yep, tests are failing because this bug isnt fixed yep: https://travis-ci.org/openresty/lua-upstream-nginx-module/jobs/187700844. To clarify more: The test case in this pullreq will pass when issue will be fixed. Cant find the exact problem location |
|
@amgorb I cannot merge a PR with failing tests to break our workflow. A corresponding fix is required. |
No description provided.