implement webpack chunks file updating using ast manipulation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
force-pushed
the
no-server-minification
branch
from
fe74186
to
7d5af2d
Compare
dario-piotrowicz
force-pushed
the
no-server-minification
branch
from
7d5af2d
to
a06218f
Compare
|
That's amazing @dario-piotrowicz Could you please update I need to go for 1h, I'll review after that. Thanks! |
Thanks ❤️
I've removed the section regarding updating the config file entirely as I think that that is now totally unnecessary and that we should not bother telling users to set the |
...uild/patches/investigated/update-webpack-chunks-file/test-fixtures/minified-webpacks-file.js
Outdated
Show resolved
Hide resolved
petebacondarwin
approved these changes
Sep 20, 2024
builder/src/build/patches/investigated/update-webpack-chunks-file/index.ts
Outdated
Show resolved
Hide resolved
.../build/patches/investigated/update-webpack-chunks-file/get-chunk-installation-identifiers.ts
Outdated
Show resolved
Hide resolved
.../build/patches/investigated/update-webpack-chunks-file/get-chunk-installation-identifiers.ts
Show resolved
Hide resolved
...d/patches/investigated/update-webpack-chunks-file/get-updated-webpack-chunks-file-content.ts
Outdated
Show resolved
Hide resolved
...estigated/update-webpack-chunks-file/get-file-content-with-updated-webpack-require-f-code.ts
Outdated
Show resolved
Hide resolved
...estigated/update-webpack-chunks-file/get-file-content-with-updated-webpack-require-f-code.ts
Outdated
Show resolved
Hide resolved
...estigated/update-webpack-chunks-file/get-file-content-with-updated-webpack-require-f-code.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Sep 20, 2024
vicb
approved these changes
Sep 20, 2024
...d/patches/investigated/update-webpack-chunks-file/get-chunk-installation-identifiers.test.ts
Outdated
Show resolved
Hide resolved
.../build/patches/investigated/update-webpack-chunks-file/get-chunk-installation-identifiers.ts
Show resolved
Hide resolved
.../build/patches/investigated/update-webpack-chunks-file/get-chunk-installation-identifiers.ts
Outdated
Show resolved
Hide resolved
.../build/patches/investigated/update-webpack-chunks-file/get-chunk-installation-identifiers.ts
Show resolved
Hide resolved
builder/src/build/patches/investigated/update-webpack-chunks-file/index.ts
Show resolved
Hide resolved
builder/src/build/patches/investigated/update-webpack-chunks-file/index.ts
Outdated
Show resolved
Hide resolved
...uild/patches/investigated/update-webpack-chunks-file/test-fixtures/minified-webpacks-file.js
Outdated
Show resolved
Hide resolved
dario-piotrowicz
force-pushed
the
no-server-minification
branch
from
65d30a6
to
d009803
Compare
this allows us not to have to require the use of the `serverMinification: false` option (as we're no longer relying on known variable names)
Co-authored-by: Pete Bacon Darwin <pbacondarwin@cloudflare.com>
dario-piotrowicz
force-pushed
the
no-server-minification
branch
from
d009803
to
5272a2a
Compare
add ts-doc comments to newly introduced functions
generalize `getWEbpackChunksFileTsSource` to `tsParseFile`
update webpackFRequireFunction detection not to use unclear `find(Boolean)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows us not to have to require the use of the
serverMinification: falseoption(as we're no longer relying on known variable names)