fixup! implement webpack chunks file updating using ast manipulation

introduce `functionUsesChunkInstallationVariables` to make code clearer
opennextjs · Sep 20, 2024 · 50b65e2 · 50b65e2
1 parent 12d1ed8
commit 50b65e2
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/...igated/update-webpack-chunks-file/get-file-content-with-updated-webpack-f-require-code.ts b/...igated/update-webpack-chunks-file/get-file-content-with-updated-webpack-f-require-code.ts
@@ -17,11 +17,10 @@ export async function getFileContentWithUpdatedWebpackFRequireCode(
       const binaryExpressionRight = binaryExpression.getRight();
       const binaryExpressionRightText = binaryExpressionRight.getText();
 
-      if (
-        !binaryExpressionRightText.includes(installChunk) ||
-        !binaryExpressionRightText.includes(installedChunks)
-      )
-        return;
+      const functionUsesChunkInstallationVariables =
+        binaryExpressionRightText.includes(installChunk) &&
+        binaryExpressionRightText.includes(installedChunks);
+      if (!functionUsesChunkInstallationVariables) return;
 
       if (!binaryExpressionRight.isKind(ts.SyntaxKind.ArrowFunction)) return;