RESTWS-955: Add support for person attribute of type Location #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherman22
force-pushed
the
RESTWS-955
branch
from
54448ff
to
ab1332c
Compare
|
I think the fix we need here is quite different. Specifically, I think we can leave the getter alone, but need to add logic to the setter so that if the supplied value is a UUID, we load the necessary location and set that as the attribute value. That way, we're still storing the |
mherman22
force-pushed
the
RESTWS-955
branch
2 times, most recently
from
c7be312
to
5b681a2
Compare
mherman22
force-pushed
the
RESTWS-955
branch
from
5b681a2
to
ade1123
Compare
3 tasks
ibacher
reviewed
Sep 18, 2024
| return false; | ||
| } | ||
|
|
||
| private boolean isValidUUID(String value) { |
There was a problem hiding this comment.
Please use RestUtil.isValidUuid() for this.
Comment on lines
103
to
105
| if (setLocationIfUUID(personAttribute, value)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think I'd probably just inline setLocationIfUUID() here. I don't see a lot of value in having a separate method.
ibacher
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/RESTWS-955
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master