Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) O3-2113 : Setup playwright and add login e2e test #740

Merged
merged 24 commits into from
Aug 21, 2023

Conversation

RandilaP
Copy link
Contributor

@RandilaP RandilaP commented Jul 31, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

The Goal of this PR is to setup the core repository for E2E testing with playwright and add login and Logout E2E test

Screenshots

image

Related Issue

https://issues.openmrs.org/browse/O3-2113

Other

@RandilaP
Copy link
Contributor Author

@Piumal1999 @jayasanka-sack Could you please review this

@RandilaP
Copy link
Contributor Author

RandilaP commented Aug 5, 2023

@anjula-sack @Piumal1999 @jayasanka-sack Could you please run the workflows

@RandilaP
Copy link
Contributor Author

RandilaP commented Aug 7, 2023

@anjula-sack @Piumal1999 @jayasanka-sack Could you please approve approve the workflow

Copy link
Collaborator

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RandilaP This should be ignored

@RandilaP
Copy link
Contributor Author

RandilaP commented Aug 7, 2023

@anjula-sack Could you please approve the workflow

.env Outdated Show resolved Hide resolved
e2e/storageState.json Outdated Show resolved Hide resolved
@RandilaP
Copy link
Contributor Author

@jayasanka-sack

@RandilaP
Copy link
Contributor Author

1 similar comment
@RandilaP
Copy link
Contributor Author

@RandilaP
Copy link
Contributor Author

@anjula-sack @jayasanka-sack @Piumal1999 Why is these report bundle and check documentations are failing

@RandilaP
Copy link
Contributor Author

@anjula-sack
Copy link
Collaborator

@RandilaP Go to this file https://raw.githubusercontent.com/openmrs/openmrs-esm-core/main/docs/main/upgrade_3_to_4.md
and replace the link https://jestjs.io/docs/28.x/migration-guide with this link https://jestjs.io/blog/2022/04/25/jest-28

@RandilaP
Copy link
Contributor Author

e2e/fixtures/index.ts Outdated Show resolved Hide resolved
e2e/commands/index.ts Outdated Show resolved Hide resolved
@RandilaP
Copy link
Contributor Author

@anjula-sack

@RandilaP
Copy link
Contributor Author

@anjula-sack

.github/workflows/e2e.yml Show resolved Hide resolved
.github/workflows/e2e.yml Show resolved Hide resolved
@RandilaP
Copy link
Contributor Author

@anjula-sack

@anjula-sack
Copy link
Collaborator

@RandilaP Can you undo the change?

@RandilaP
Copy link
Contributor Author

@anjula-sack

@anjula-sack
Copy link
Collaborator

@RandilaP Add cache dependency back

@anjula-sack
Copy link
Collaborator

Replace this link as well https://zeroheight.com/23a080e38/p/880723--introduction

@RandilaP
Copy link
Contributor Author

Replace this link as well https://zeroheight.com/23a080e38/p/880723--introduction

@anjula-sack With which link

@anjula-sack
Copy link
Collaborator

Replace this link as well https://zeroheight.com/23a080e38/p/880723--introduction

@anjula-sack With which link

Just remove it @RandilaP

@RandilaP
Copy link
Contributor Author

@anjula-sack What link should I replace with that failing link

@anjula-sack
Copy link
Collaborator

@anjula-sack What link should I replace with that failing link

Just remove it

@RandilaP
Copy link
Contributor Author

@anjula-sack

@RandilaP
Copy link
Contributor Author

@anjula-sack Can we merge this because the errors that are showing because of the server failure in JIRA

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RandilaP! The link check job has failed because Jira is down. Therefore, I will merge the PR.

@RandilaP
Copy link
Contributor Author

@jayasanka-sack Thank you

@jayasanka-sack jayasanka-sack dismissed anjula-sack’s stale review August 21, 2023 13:16

Requested changes has been fixed

@jayasanka-sack jayasanka-sack merged commit da40164 into openmrs:main Aug 21, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants