Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add translation override for district address field #1188

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

makombe
Copy link
Contributor

@makombe makombe commented Oct 28, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Since patient fhir object returns district for the address field, it is necessary that we add this to our translations to make it possible to override such.
Screenshot from 2024-10-28 22-28-46

Screenshots

Related Issue

Other

@donaldkibet
Copy link
Member

@makombe is the failing e2e related to this change?

@makombe
Copy link
Contributor Author

makombe commented Oct 29, 2024

@makombe is the failing e2e related to this change?

Not really, the test are now ok @donaldkibet

@denniskigen
Copy link
Member

Thanks, @makombe.

@denniskigen denniskigen merged commit 3a2620e into openmrs:main Oct 29, 2024
14 checks passed
@denniskigen denniskigen changed the title (fix) Add translation override for district address field (feat) Add translation override for district address field Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants