(feat) Extend PageHeader component to accept additional HTML attributes

openmrs · Aug 26, 2024 · 886629e · 886629e
1 parent 4a8326d
commit 886629e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/framework/esm-framework/docs/API.md b/packages/framework/esm-framework/docs/API.md
@@ -2042,7 +2042,7 @@ on its own, and the PageHeaderContent component is not needed.
 
 #### Defined in
 
-[packages/framework/esm-styleguide/src/page-header/page-header.component.tsx:85](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-styleguide/src/page-header/page-header.component.tsx#L85)
+[packages/framework/esm-styleguide/src/page-header/page-header.component.tsx:89](https://github.com/openmrs/openmrs-esm-core/blob/main/packages/framework/esm-styleguide/src/page-header/page-header.component.tsx#L89)
 
 ___
 

diff --git a/packages/framework/esm-styleguide/src/page-header/page-header.component.tsx b/packages/framework/esm-styleguide/src/page-header/page-header.component.tsx
@@ -56,12 +56,16 @@ const isPageHeaderWrapperProps = (props: any): props is PageHeaderWrapperProps =
  */
 export const PageHeader: React.FC<PageHeaderProps> = (props) => {
   if (isPageHeaderWrapperProps(props)) {
-    const { children, className } = props;
-    return <div className={classNames(styles.pageHeader, className)}>{children}</div>;
+    const { children, className, ...rest } = props;
+    return (
+      <div className={classNames(styles.pageHeader, className)} {...rest}>
+        {children}
+      </div>
+    );
   } else {
-    const { title, illustration, className } = props;
+    const { title, illustration, className, ...rest } = props;
     return (
-      <div className={classNames(styles.pageHeader, className)}>
+      <div className={classNames(styles.pageHeader, className)} {...rest}>
         <PageHeaderContent title={title} illustration={illustration} />
       </div>
     );