(fix) - O3-3189 - fix useOpemrsInfinite hook to correctly take in URL…

… object (#1146)
openmrs · Sep 8, 2024 · 2c36c62 · 2c36c62
1 parent 3f27fab
commit 2c36c62
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/framework/esm-react-utils/src/useOpenmrsFetchAll.ts b/packages/framework/esm-react-utils/src/useOpenmrsFetchAll.ts
@@ -56,7 +56,7 @@ export function useServerFetchAll<T, R>(
     if (hasMore && !error) {
       loadMore();
     }
-  });
+  }, [hasMore]);
 
   if (options.partialData) {
     return response;

diff --git a/packages/framework/esm-react-utils/src/useOpenmrsInfinite.ts b/packages/framework/esm-react-utils/src/useOpenmrsInfinite.ts
@@ -112,9 +112,9 @@ export function useServerInfinite<T, R>(
   const { getNextUrl, getTotalCount, getData } = serverPaginationHandlers;
   const fetcher: (key: string) => Promise<FetchResponse<R>> = options.fetcher ?? openmrsFetch;
   const getKey = useCallback(
-    (pageIndex: number, previousPageData: FetchResponse<R>) => {
+    (pageIndex: number, previousPageData: FetchResponse<R>): string | null => {
       if (pageIndex == 0) {
-        return url;
+        return url?.toString() ?? null;
       } else {
         return serverPaginationHandlers.getNextUrl(previousPageData.data);
       }