Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4101: Configure service types and billables to be used in billing app #853

Closed
wants to merge 3 commits into from

Conversation

WodPachua
Copy link

@WodPachua WodPachua commented Oct 18, 2024

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

  • I have configured the service types and billable services

Screenshots

configure billing

Related Issue

ISSUE 03-4101

@WodPachua
Copy link
Author

@ODORA0 here is the PR to fix the billables

"serviceTypes": {
"billableService": "0dfe7d9f-1dc9-4e68-b4cb-d19e1a006c54"
},
"defaultCurrency": "UGX"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be UG. The Pr looks good

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I was just testing... we could use USD since its more neutral and universally used


<!-- Temporary work around to add prices via liquibase, as we wait for for the billable service edit feature -->
<changeSet id="add_item_prices" author="wodpachua">
<sql>SET foreign_key_checks = 0;</sql>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkayiwa Thanks Daniel, have made the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you would change your sql insertions into some sort of csv files. Just like you have done for the rest.

Copy link
Author

@WodPachua WodPachua Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkayiwa Yes, but prices are not a supported domain currently in initializer... because its data that changes, so it has to be added by the user via the UI or via such SQL instructions as I had done previously.

Thats why I had used the SQL insertations, since we don't have an edit mode to edit the services added via initializer and add prices to them. And we needed to demo here... so this was a temporary work around until the edit mode could be introduced, or a way to add support for prices

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ODORA0
Copy link
Member

ODORA0 commented Nov 5, 2024

@dkayiwa We may need to close this since service types were added to the billing concepts csv #857

@WodPachua
Copy link
Author

Hakuna Matata... @ODORA0

@WodPachua WodPachua closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants