-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the .frequency_id
argument required by rlang::warn
#152
Conversation
brancengregory
commented
Jul 11, 2023
@andrewjbe If the checks pass this is ready. After merge we'll bump the last semver value, i.e. Z in X.Y.Z |
GH Actions seem to be failing because of issues with |
The |
I updated the ojo_list_tables() testthat snapshot to accomodate the changes to the DB. I also removed the ".data$" prefix from arguments to tidyselect functions, as this is now deprecated and throws a warning.
The GitHub actions checks are failing right now for two reasons:
I'm not sure what's going on with 1, but 2 should be easily fixed by giving |
The DB roles are fixed, and the windows runner now works as a result. I think we might want to start from scratch with our renv setup to solve the other outstanding issue. |
Renv from scratch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.frequenccy_id
argument added, renv
removed so that GH Actions will continue working