Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the .frequency_id argument required by rlang::warn #152

Merged
merged 19 commits into from
Aug 28, 2023
Merged

Conversation

brancengregory
Copy link
Member

Error in `rlang::warn()`:
! `.frequency_id` must be supplied with `.frequency`.
Backtrace:
 1. ojodb::ojo_collect(...)
 2. rlang::warn(...)
 3. rlang:::needs_signal(.frequency, .frequency_id, warning_freq_env, "rlib_warning_verbosity")

@brancengregory brancengregory added the bug Something isn't working label Jul 11, 2023
@brancengregory
Copy link
Member Author

@andrewjbe If the checks pass this is ready. After merge we'll bump the last semver value, i.e. Z in X.Y.Z

@andrewjbe
Copy link
Collaborator

GH Actions seem to be failing because of issues with {pak} -- is there something off w/ the lock file or something like that?

@andrewjbe
Copy link
Collaborator

The ojo_list_schemas() test is also failing, but it looks like it's because the schemas actually changed. So we should just need to make a new snapshot and it should work, I think

andrewjbe added 6 commits August 23, 2023 15:29
I updated the ojo_list_tables() testthat snapshot to accomodate the changes to the DB. I also removed the ".data$" prefix from arguments to tidyselect functions, as this is now deprecated and throws a warning.
@andrewjbe
Copy link
Collaborator

andrewjbe commented Aug 23, 2023

The GitHub actions checks are failing right now for two reasons:

  1. Something about our {renv} / {pak} setup is screwed up; on all platforms except Windows, the workflow hits an error during the setup-r-dependencies@v2 step. The error is Error in remote(function(...) { : Subprocess is busy or cannot start, which is related to {pak} attempting to create a lock file (I think).
  2. The GitHub actions user on our database does not have permission to see the new oscn schema, so it's getting different results than you and I do with our users for ojo_list_schemas() and the testthat tests are failing as a result.

I'm not sure what's going on with 1, but 2 should be easily fixed by giving all_table_reader access to the new oscn schema once I get the go-ahead from @brancengregory

@andrewjbe
Copy link
Collaborator

The DB roles are fixed, and the windows runner now works as a result. I think we might want to start from scratch with our renv setup to solve the other outstanding issue.

Copy link
Collaborator

@andrewjbe andrewjbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.frequenccy_id argument added, renv removed so that GH Actions will continue working

@andrewjbe andrewjbe merged commit 619ee3d into main Aug 28, 2023
7 checks passed
@andrewjbe andrewjbe deleted the rlang-bug branch August 29, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants