Django upgrade #2017
Open
Django upgrade #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things to note... Run tests now needs a secret key for more information see https://docs.djangoproject.com/en/4.1/releases/3.2/#security Autofield now needs to be declared in settings, for more information see https://docs.djangoproject.com/en/4.1/releases/3.2/#customizing-type-of-auto-created-primary-keys staticfiles template library has been removed. We should now use static. For more information see https://docs.djangoproject.com/en/4.1/releases/3.0/#features-removed-in-3-0
fredkingham
force-pushed
the
django-upgrade
branch
from
fd245dc
to
a29eed3
Compare
added 3 commits
March 6, 2023 16:11
The django upgrade did not go out in 0.23 and has been moved into 0.24 this changes the change log/upgrading information from 23 into 0.24 as well.
davidmiller
reviewed
May 24, 2023
| @@ -17,7 +17,7 @@ def settings(request): | |||
| """ | |||
| Put all settings in locals() for our templte context. | |||
| """ | |||
| return {x: getattr(s, x) for x in dir(s)} | |||
| return {x: getattr(s, x) for x in dir(s) if hasattr(s, x)} | |||
There was a problem hiding this comment.
Why is this here as part of this PR?
davidmiller
reviewed
May 24, 2023
| @@ -87,7 +87,7 @@ def m2m(x): | |||
| def _get_field_type(cls, name): | |||
| try: | |||
| return type(cls._meta.get_field(name)) | |||
| except models.FieldDoesNotExist: | |||
| except FieldDoesNotExist: | |||
There was a problem hiding this comment.
Why is this here as part of this PR?
davidmiller
reviewed
May 24, 2023
| @@ -814,7 +814,7 @@ def test_field_schema(self, patient_list): | |||
|
|
|||
| class AbstractDemographicsTestCase(OpalTestCase): | |||
| def test_name(self): | |||
| d = models.Demographics(first_name='Jane', | |||
| d = Demographics(first_name='Jane', | |||
There was a problem hiding this comment.
Why is this here as part of this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the Dependency Graph
More details:
https://github.com/openhealthcare/Development/issues/57