Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules list: Store search query when leaving page/reloading & Improve code #2823

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Rules list: Store search query when leaving page/reloading & Improve code #2823

merged 1 commit into from
Oct 24, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Oct 24, 2024 •
edited
Loading

As rules-list.vue is used by scenes and scripts list, this applies to them as well.

@florian-h05
Rules/Scenes/Scripts list: Store the search query when leaving the pa…
c8ccb74 
…ge or reloading & Code enhancements

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@relativeci RelativeCI
Copy link

relativeci bot commented Oct 24, 2024

#2397 Bundle Size — 10.85MiB (~+0.01%).

c8ccb74(current) vs 0a58424 main#2394(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2397		      Baseline
#2394
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 23% 23.71%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2923 2923
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2397		      Baseline
#2394
Regression  JS 9.06MiB (~+0.01%) 9.06MiB
No change  CSS 864.03KiB 864.03KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch florian-h05:rules-list-improveme... Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Oct 24, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Oct 24, 2024
@florian-h05 florian-h05 merged commit 521d67b into openhab:main Oct 24, 2024
8 checks passed
@florian-h05 florian-h05 deleted the rules-list-improvements branch October 24, 2024 10:08
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Oct 26, 2024
@florian-h05
Fix flickering of list pages when updating
f574b79 
Partly regression from openhab#2823 and openhab#2827.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@florian-h05 florian-h05 mentioned this pull request Oct 26, 2024
Merged
florian-h05 added a commit that referenced this pull request Oct 26, 2024
@florian-h05
Fix flickering of list pages when updating (#2837)
c6dda3c 
Fixes Items list flickering when an Item is added, updated or removed.

Fixes the same issue for other lists, where this is a regression from
#2823 and #2827.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
1 participant
@florian-h05