oh-cell: Fix headerBadgeColor #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The color attribute for the header badges in the oh-cell were not dynamic and as a result setting headerBadgeColor in the cell config caused a malformed color class to be added to the badge. Signed-off-by: JustinGeorgi <77952587+JustinGeorgi@users.noreply.github.com>
#2381 Bundle Size — 10.84MiB (~-0.01%).e120aec(current) vs 0396d31 main#2380(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2381 |
Baseline #2380 |
|
|---|---|---|
 Initial JS |
1.89MiB(~-0.01%) |
1.89MiB |
 Initial CSS |
577.21KiB |
577.21KiB |
| Cache Invalidation |
24.09% |
24.09% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2919 |
2919 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 
1 change 1 improvement
| Current #2381 |
Baseline #2380 |
|
|---|---|---|
| JS |
9.05MiB (~-0.01%) |
9.05MiB |
| CSS |
863.98KiB |
863.98KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch JustinGeorgi:jag-cellbadge-fix Project dashboard
Generated by RelativeCI Documentation Report issue
florian-h05
changed the title
|
@JustinGeorgi Can you please provide a valid email address for the sign-off according to https://www.openhab.org/docs/developer/contributing.html#sign-your-work in future PRs? |
Oh, sorry about that! I used the github web interface because this was so quick and I wasn't where I could get to a dev environment easily. I had no idea it wouldn't just use my profile email. I'll keep an eye out next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color attribute for the header badges in the oh-cell were not dynamic and as a result setting headerBadgeColor in the cell config caused a malformed color class to be added to the badge.