Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings pages: Fix double scrollbars by hiding y-overflow in block-narrow #2802

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Settings pages: Fix double scrollbars by hiding y-overflow in block-narrow #2802

merged 1 commit into from
Oct 6, 2024

Conversation

sonic74
Copy link
Contributor

@sonic74 sonic74 commented Oct 6, 2024 •
edited by florian-h05
Loading

Fixes #2788.

@sonic74
Widen hidden CSS to all overflow to fix openhab#2788
d2b3aff 
Signed-off-by: Sven Killig <sven@killig.de>
@sonic74 sonic74 mentioned this pull request Oct 6, 2024
Closed
@florian-h05 florian-h05 changed the title Widen hidden CSS to all overflow to fix #2788 Settings pages: Fix double scrollbars by hiding y-overflow in block-narrow Oct 6, 2024
florian-h05
florian-h05 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
I haven't found regressions when testing this, so let's give it a try 👍

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Oct 6, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Oct 6, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Oct 6, 2024

#2362 Bundle Size — 10.84MiB (~-0.01%).

d2b3aff(current) vs 0767c91 main#2361(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#2362		      Baseline
#2361
No change  Initial JS 1.89MiB 1.89MiB
Improvement  Initial CSS 577.02KiB(~-0.01%) 577.02KiB
Change  Cache Invalidation 22.68% 24.09%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2919 2919
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#2362		      Baseline
#2361
No change  JS 9.05MiB 9.05MiB
Improvement  CSS 863.79KiB (~-0.01%) 863.79KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis report Branch sonic74:patch-1 Project dashboard

Generated by RelativeCI Documentation Report issue

@florian-h05 florian-h05 merged commit 3efc1a8 into openhab:main Oct 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

@ghys ghys Awaiting requested review from ghys ghys is a code owner

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Double scrollbars on /settings/items/
2 participants
@sonic74 @florian-h05