Fix safe area styling issues with card and card contents #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2360 Bundle Size — 10.84MiB (~+0.01%).f477088(current) vs 0a3fb92 main#2350(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2360 |
Baseline #2350 |
|
|---|---|---|
 Initial JS |
1.89MiB(~+0.01%) |
1.89MiB |
| Initial CSS |
577.02KiB(+0.04%) |
576.8KiB |
 Cache Invalidation |
24.09% |
22.77% |
 Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2919(+0.03%) |
2918 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 2 changes 2 regressions
| Current #2360 |
Baseline #2350 |
|
|---|---|---|
| JS |
9.05MiB (~+0.01%) |
9.05MiB |
| CSS |
863.79KiB (+0.03%) |
863.56KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch florian-h05:safe-area-issues Project dashboard
Generated by RelativeCI Documentation Report issue
This fixes ugly styling issues with too large margin/padding on iOS devices due to safe areas getting applied to children of f7-card, even though f7-card already respects the safe areas. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
force-pushed
the
safe-area-issues
branch
from
dad6e15
to
f477088
Compare
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 6, 2024
Regression from openhab#2801. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 6, 2024
Regression from openhab#2801. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Oct 6, 2024
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 7, 2024
Regression from openhab#2801. Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 7, 2024
Regression from openhab#2801. Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 9, 2024
Regression from openhab#2801. This fixes difficulties with overwriting that style in widgets. Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
added a commit
to florian-h05/openhab-conf
that referenced
this pull request
Oct 9, 2024
…rientation" This reverts commit 36c2479. The root problem has been fixed in openhab/openhab-webui#2801, so this is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ugly styling issues with too large margin/padding on iOS devices due to safe areas getting applied to children of f7-card, even though f7-card already respects the safe areas.
This removes the space marked in the following screenshots: