Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Apply Fix SSE failure toast container not removed #2182

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

florian-h05
Copy link
Contributor

This re-applies the fix from #2075, which must have been lost while rebasing #1987.

This re-applies the fix from openhab#2075, which must have been lost while rebasing openhab#1987.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner November 22, 2023 14:15
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI regression labels Nov 22, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Nov 22, 2023
Copy link

relativeci bot commented Nov 22, 2023

Job #1266: Bundle Size — 15.81MiB (+0.29%).

482258f(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1266
     Baseline
Job #1158
Regression  Initial JS 1.89MiB(+13.11%) 1.67MiB
Regression  Initial CSS 609.63KiB(+0.12%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3027(+78.06%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1266
     Baseline
Job #1158
Regression  JS 9.28MiB (+0.31%) 9.25MiB
Regression  Other 4.74MiB (+0.32%) 4.73MiB
Regression  CSS 860.87KiB (+0.16%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1266 reportView florian-h05:sse-failure-toast branch activity

@florian-h05 florian-h05 merged commit d8e29f1 into openhab:main Nov 22, 2023
6 checks passed
@florian-h05 florian-h05 deleted the sse-failure-toast branch November 22, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant