Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Things: Add copy channel functionality #2131

Merged
merged 11 commits into from
Nov 9, 2023
Merged

Things: Add copy channel functionality #2131

merged 11 commits into from
Nov 9, 2023

Conversation

d51x
Copy link
Contributor

@d51x d51x commented Oct 10, 2023

Added ability to copy channels in thing
image
image

@d51x
[MainUI] things: copy channel
9e771ef 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[MainUI] things: copy channel
a046c14 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x d51x requested a review from a team as a code owner October 10, 2023 17:53
@relativeci
Copy link

relativeci bot commented Oct 10, 2023 •
edited
Loading

Job #1250: Bundle Size — 15.75MiB (-0.05%).

8dfb230(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1250		      Baseline
Job #1158
Regression  Initial JS 1.85MiB(+11.06%) 1.67MiB
Regression  Initial CSS 609.06KiB(+0.03%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 2990(+75.88%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 2 regressions Improvement 1 improvement
                 Current
Job #1250		      Baseline
Job #1158
Improvement  JS 9.24MiB (-0.12%) 9.25MiB
Regression  Other 4.73MiB (+0.03%) 4.73MiB
Regression  CSS 860.29KiB (+0.09%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1250 report View d51x:thing_channel_copy branch activity

florian-h05
florian-h05 requested changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Please have a look at my comments.

bundles/org.openhab.ui/web/src/components/thing/channel-link.vue Outdated Show resolved Hide resolved
bundles/org.openhab.ui/web/src/pages/settings/things/channel/channel-copy.vue Outdated Show resolved Hide resolved
bundles/org.openhab.ui/web/src/pages/settings/things/channel/channel-copy.vue Outdated Show resolved Hide resolved
bundles/org.openhab.ui/web/src/pages/settings/things/channel/channel-copy.vue Outdated Show resolved Hide resolved
@florian-h05 florian-h05 changed the title Thing channel copy Things: Add copy channel functionality Nov 4, 2023
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Nov 4, 2023
d51x and others added 3 commits November 5, 2023 10:17
@d51x @florian-h05
Update bundles/org.openhab.ui/web/src/components/thing/channel-link.vue
000eb4a 
Co-authored-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: d51x <dimonich110@gmail.com>
@d51x @florian-h05
Update bundles/org.openhab.ui/web/src/pages/settings/things/channel/c…
f5e6743 
…hannel-copy.vue

Co-authored-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: d51x <dimonich110@gmail.com>
@d51x @florian-h05
Update bundles/org.openhab.ui/web/src/pages/settings/things/channel/c…
d984a04 
…hannel-copy.vue

Co-authored-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: d51x <dimonich110@gmail.com>
@d51x
[MainUI] things: fix cope channel page title
81c2b42 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[MainUI] things: add subtitle for add channel page
ff8c6d0 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[MainUI] things: copy channel only for UI-channels
c82d544 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@d51x
[MainUI] things: remove channel only for UI-channels
ec68b9d 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
florian-h05
florian-h05 reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just one minor comment.

bundles/org.openhab.ui/web/src/components/thing/channel-link.vue Outdated Show resolved Hide resolved
@d51x
[MainUI] things: removed unused import
7abca01 
Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
florian-h05
florian-h05 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I have noticed one more thing, but I fixed that myself.

bundles/org.openhab.ui/web/src/components/thing/channel-link.vue Outdated Show resolved Hide resolved
@florian-h05
Update bundles/org.openhab.ui/web/src/components/thing/channel-link.vue
8dfb230 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added this to the 4.1 milestone Nov 9, 2023
@florian-h05 florian-h05 merged commit 18ad473 into openhab:main Nov 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@d51x @florian-h05