-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockly] Support Quantity in more math blocks #2041
Conversation
Job #1178: Bundle Size — 15.78MiB (+0.14%).Warning Bundle contains 16 duplicate packages – View duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
Bundle size by type
View job #1178 report View stefan-hoehn:blockly_quantity_ma... branch activity |
0969054
to
d1c069f
Compare
d1c069f
to
1079d45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I have fixed two bugs:
- the lead type was not correctly determined due to a typo
- the lead type did not default to
Number
if both input were vars, which made the block have not set an output type
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
144facd
to
fa311d5
Compare
fixes #2001
Note that there is a special case on min/max if the inputs are not of equal type an error will be shown to user:
In the special case of variables Blockly does its best to detect the right code to be generated for the min/max block:
Here are working examples that depict what is possible: