[blockly] Allow item xxx to be used for get xxx of item
#2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Job #1126: Bundle Size — 15.75MiB (~-0.01%).Metrics (1 change)
Total size by type (2 changes)
|
florian-h05
changed the title
florian-h05
changed the title
item xxx to be used for get xxx of item
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
…2037) The block can now take both “get item item xxx” or (new) “item xxx” directly. I have also added some hint in the help tooltip that clarifies how to work with the block when using it through variables because Blockly has to make an assumption due to the fact that it cannot detect what is provided in the variable. See https://community.openhab.org/t/less-then-greater-then-comparison-return-value-seems-to-be-inverted/148910/9. Signed-off-by: Stefan Höhn <mail@stefanhoehn.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
…2037) The block can now take both “get item item xxx” or (new) “item xxx” directly. I have also added some hint in the help tooltip that clarifies how to work with the block when using it through variables because Blockly has to make an assumption due to the fact that it cannot detect what is provided in the variable. See https://community.openhab.org/t/less-then-greater-then-comparison-return-value-seems-to-be-inverted/148910/9. Signed-off-by: Stefan Höhn <mail@stefanhoehn.com> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
digitaldan
pushed a commit
to digitaldan/openhab-webui
that referenced
this pull request
Sep 24, 2023
…2037) The block can now take both “get item item xxx” or (new) “item xxx” directly. I have also added some hint in the help tooltip that clarifies how to work with the block when using it through variables because Blockly has to make an assumption due to the fact that it cannot detect what is provided in the variable. See https://community.openhab.org/t/less-then-greater-then-comparison-return-value-seems-to-be-inverted/148910/9. Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block can now take both “get item item xxx” or (new) “item xxx” directly. I have also added some hint in the help tooltip that clarifies how to work with the block when using it through variables because Blockly has to make an assumption due to the fact that it cannot detect what is provided in the variable.
see https://community.openhab.org/t/less-then-greater-then-comparison-return-value-seems-to-be-inverted/148910/9