Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap editor: Fix frequency and refresh parameters #2033

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Aug 21, 2023

Signed-off-by: Mark Herwege mark.herwege@telenet.be

These parameters should be number instead of text.

See #1487 (comment)

@mherwege mherwege requested review from ghys, peuter, a team and kaikreuzer as code owners August 21, 2023 15:33
@relativeci
Copy link

relativeci bot commented Aug 21, 2023

Job #1124: Bundle Size — 15.75MiB (~-0.01%).

e9b7033(current) vs 79fbf89 main#1123(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1124
     Baseline
Job #1123
Initial JS 1.67MiB 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 0.11% 93.94%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (1 change)
                 Current
Job #1124
     Baseline
Job #1123
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.25MiB 9.25MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~-0.01%) 4.72MiB

View job #1124 reportView main branch activity

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@ghys ghys merged commit 5900864 into openhab:main Sep 5, 2023
4 checks passed
@mherwege mherwege deleted the sendfrequency_fix branch September 5, 2023 20:56
stefan-hoehn pushed a commit to stefan-hoehn/openhab-webui that referenced this pull request Sep 23, 2023
…#2033)

These parameters should be number instead of text.

See: openhab#1487 (comment)

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
digitaldan pushed a commit to digitaldan/openhab-webui that referenced this pull request Sep 24, 2023
…#2033)

These parameters should be number instead of text.

See: openhab#1487 (comment)

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@florian-h05 florian-h05 changed the title [mainui] Sitemap editor fix frequency and refresh parameters Sitemap editor: Fix frequency and refresh parameters Oct 8, 2023
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Oct 8, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants