[BasicUI] Handle the new parameter "staticIcon" #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
enhancement
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
basicui_staticIcon
branch
from
784ac70
to
b89df6d
Compare
lolodomo
added
rebuild
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Aug 14, 2023
Depends on openhab/openhab-core#3759 and openhab#1998 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Aug 14, 2023
Depends on openhab/openhab-core#3759 and openhab#1998 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Aug 15, 2023
Depends on openhab/openhab-core#3759 and openhab#1998 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
@kaikreuzer : this PR is only 21 new lines. Could you review it please? |
|
@lolodomo Could you please rebase this PR? |
Kai, it is done. |
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Sep 9, 2023
Depends on openhab/openhab-core#3759 and openhab#1998 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
stefan-hoehn
pushed a commit
to stefan-hoehn/openhab-webui
that referenced
this pull request
Sep 23, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
JustinGeorgi
pushed a commit
to JustinGeorgi/openhab-webui
that referenced
this pull request
Sep 24, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: jgeorgi <justin.georgi@gmail.com>
digitaldan
pushed a commit
to digitaldan/openhab-webui
that referenced
this pull request
Sep 24, 2023
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated. Depends on openhab/openhab-core#3735 Related to openhab/openhab-android#3404 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Oct 4, 2023
Depends on openhab/openhab-core#3820 and openhab#1998 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Oct 7, 2023
Depends on openhab/openhab-core#3820 and openhab#1998 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Oct 7, 2023
Depends on openhab/openhab-core#3820 and openhab#1998 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added a commit
to lolodomo/openhab-webui
that referenced
this pull request
Oct 7, 2023
Depends on openhab/openhab-core#3820 and openhab#1998 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
pushed a commit
that referenced
this pull request
Oct 26, 2023
Depends on openhab/openhab-core#3820 and #1998 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set on a sitemap element, Basic UI ignores the item state when initially requesting the OH icon and do not request it again when the item state is updated.
Depends on openhab/openhab-core#3735
Related to openhab/openhab-android#3404
Signed-off-by: Laurent Garnier lg.hc@free.fr