Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitezmap: new Buttongrid element #2176

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo marked this pull request as draft December 16, 2023 11:49
Copy link

netlify bot commented Dec 16, 2023

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Name Link
🔨 Latest commit 5e5157c
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/657dcf442cf0a40008202361
😎 Deploy Preview https://deploy-preview-2176--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lolodomo lolodomo marked this pull request as ready for review December 16, 2023 12:29
@lolodomo lolodomo force-pushed the sitemap_buttongrid branch 3 times, most recently from a1b1e89 to 7f7f038 Compare December 16, 2023 12:52
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for providing this new component and the documentation.
Please adapt the few comments from my side.

ui/sitemaps.md Outdated Show resolved Hide resolved
ui/sitemaps.md Outdated Show resolved Hide resolved
ui/sitemaps.md Outdated Show resolved Hide resolved
ui/sitemaps.md Outdated Show resolved Hide resolved
ui/sitemaps.md Outdated Show resolved Hide resolved
@stefan-hoehn stefan-hoehn added this to the 4.1 milestone Dec 16, 2023
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@stefan-hoehn stefan-hoehn merged commit b656ddc into openhab:main Dec 16, 2023
5 checks passed
@lolodomo
Copy link
Contributor Author

Thank you for your fast review(s).

@lolodomo lolodomo deleted the sitemap_buttongrid branch December 16, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants