Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ism8] Add manufacturer Wolf to add-on name field #17747

Closed
wants to merge 1 commit into from
Closed

[ism8] Add manufacturer Wolf to add-on name field #17747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.openhab.binding.ism8/src/main/resources/OH-INF/addon/addon.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
xsi:schemaLocation="https://openhab.org/schemas/addon/v1.0.0 https://openhab.org/schemas/addon-1.0.0.xsd">

<type>binding</type>
<name>ISM8 Binding</name>
<name>Wolf ISM8 Binding</name>
Copy link
Contributor

@jlaur jlaur Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the I18N properties file after this change:

openhab-addons/bundles/org.openhab.binding.ism8/src/main/resources/OH-INF/i18n/ism8.properties

Line 3 in 772026e

addon.ism8.name = ISM8 Binding

Also, when renaming the binding, for consistency it should probably also be renamed in these places:
https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.binding.ism8#ism8-binding (the headline, see #17675)

openhab-addons/bundles/org.openhab.binding.ism8/pom.xml

Line 15 in 772026e

<name>openHAB Add-ons :: Bundles :: Ism8 Binding</name>

openhab-addons/bundles/org.openhab.binding.ism8/src/main/feature/feature.xml

Line 5 in 772026e

<feature name="openhab-binding-ism8" description="ism8 Binding" version="${project.version}">

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is the right approach. I think that "renaming" the binding may be too much - just to give a better search experience.
Maybe it would be better to extend the search in the UI from title to the descriptions....
...and if that is too much effort, even living with the current situation might be an option.

What are your thoughts on that? @jlaur @lsiepel?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that bindings should not be renamed just to add search words for the UI, so if the renaming otherwise doesn't make sense or seems overkill, then I would also rather prefer one of your other suggested options.

I don't know if it is feasible to use description for the search as well, but you could try to open an issue in the openhab-webui repo. At first it seems straightforward, but when looking at a description, for example this one: "This is the binding for the ISM8 card used for Wolf heating systems or other Wolf eBus devices.", I wonder if certain words should be excluded to not give too many unrelated results. At least it looks like a simple substring matcher, but maybe there is a fancy search machine behind. 😄

<description>This is the binding for the ISM8 card used for Wolf heating systems or other Wolf eBus devices.</description>
<connection>local</connection>

Expand Down