Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[solax] Initial contribution #14880

Merged
merged 34 commits into from
Aug 24, 2023
Merged

[solax] Initial contribution #14880

merged 34 commits into from
Aug 24, 2023

Commits on Jul 25, 2023

  1. Squashed all commits 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4b938df View commit details
    Browse the repository at this point in the history

  2. Change version in pom.xml to 4.1.0 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    731b1d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Metadata and README requested changes 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d5d90a4 View commit details
    Browse the repository at this point in the history

  2. Changes in the handlers, factory and discovery service from the review 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3c0e58a View commit details
    Browse the repository at this point in the history

  3. Update bundles/org.openhab.binding.solax/README.md 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2aedbf0 View commit details
    Browse the repository at this point in the history

  4. Update bundles/org.openhab.binding.solax/src/main/resources/OH-INF/th… 

    …ing/channel_types.xml

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ad8c370 View commit details
    Browse the repository at this point in the history

  5. Changes in channel types, readme and null pointer checks warnings 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6d8592c View commit details
    Browse the repository at this point in the history

  6. Remove the bridge and use only a thing / thing handler 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f1c2232 View commit details
    Browse the repository at this point in the history

  7. Fix README - the examples and the bridge/thing changes 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d418205 View commit details
    Browse the repository at this point in the history

  8. Fixed a typo in logging and renamed some constants 

    * Fix some warnings related to potential NPE access

Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b5f8028 View commit details
    Browse the repository at this point in the history

  9. Fixes from the review (see details) 

    * Remove the empty properties from the metadata file
* Various fixes in the README
* refresh -> refreshInterval in the config
* Removal of unnecessary logging
* Add descriptions and labels to channels
* Remove unused/not working channels
* Regenerate the translations of the channels with maven

Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f87a71d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Fix mvn warning and a pointer cleanup in dispose method 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    3f91205 View commit details
    Browse the repository at this point in the history

  2. Refactored the exception handling of JSON parse. Please review 

    * Change catch exception from GSON
* Ensure that if nothing is retrieved from the HTTP client, null is not
passed for parsing
* Complete refactoring of the JSON parse logic in the handler
* Remove unnecessary else in the factory for unsupported handlers

Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f9d1340 View commit details
    Browse the repository at this point in the history

  3. Update bundles/org.openhab.binding.solax/README.md 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    7c3a25b View commit details
    Browse the repository at this point in the history

  4. Update bundles/org.openhab.binding.solax/README.md 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d91bf38 View commit details
    Browse the repository at this point in the history

  5. Update bundles/org.openhab.binding.solax/README.md 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    afb926b View commit details
    Browse the repository at this point in the history

  6. Update bundles/org.openhab.binding.solax/README.md 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    bfeb0cd View commit details
    Browse the repository at this point in the history

  7. Update bundles/org.openhab.binding.solax/README.md 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1ddfd33 View commit details
    Browse the repository at this point in the history

  8. Update bundles/org.openhab.binding.solax/README.md 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f2fe3f8 View commit details
    Browse the repository at this point in the history

  9. Fix retrieveData method in local connector to return nullable 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    342c685 View commit details
    Browse the repository at this point in the history

  10. Fixes in the metadata files 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f6327aa View commit details
    Browse the repository at this point in the history

  11. Format the tables and remove channels from inverter description 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    81c45ef View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Fixes from the review 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6895cc5 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Fixes (see below) 

    * Fixed a wrong constant for the battery level
* Fixed channel types labels to be with title case
* Fixed wrong description of LocalHttpConnector class
* Fixed wrong property type constant
* Regenerated i18n file
* Removed overrides of labels and descriptions for specific channel
types
* Added I18N key for the "unable to retrieve" message
* Added a trace level log with the URI of the Wi-Fi module, together
with the request body

Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b6c65a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Update bundles/org.openhab.binding.solax/src/main/resources/OH-INF/th… 

    …ing/channel_types.xml

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    2d76fd6 View commit details
    Browse the repository at this point in the history

  2. Update bundles/org.openhab.binding.solax/src/main/resources/OH-INF/th… 

    …ing/channel_types.xml

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    26194dc View commit details
    Browse the repository at this point in the history

  3. Recreate translations 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    fa79089 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Update bundles/org.openhab.binding.solax/README.md 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    1048e09 View commit details
    Browse the repository at this point in the history

  2. Update bundles/org.openhab.binding.solax/README.md 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    baf92ca View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Update bundles/org.openhab.binding.solax/pom.xml 

    Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    44a084a View commit details
    Browse the repository at this point in the history

  2. Fix prio3 errors 

    Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    3fb3fc0 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Fix build warnings 

    * Add empty json string check
* Add serialization annotations for the fields with capital letters
* Refactor the fields with capital letters

Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater
    theater committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    9cba0d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Update bundles/org.openhab.binding.solax/src/main/java/org/openhab/bi… 

    …nding/solax/internal/connectivity/rawdata/LocalConnectRawDataBean.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1e35b5c View commit details
    Browse the repository at this point in the history

  2. Update bundles/org.openhab.binding.solax/src/main/java/org/openhab/bi… 

    …nding/solax/internal/connectivity/rawdata/LocalConnectRawDataBean.java

Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
    @theater @jlaur
    theater and jlaur authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6e17a14 View commit details
    Browse the repository at this point in the history