Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON roundtrip after Interchange.from_openmm #1089

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix JSON roundtrip after Interchange.from_openmm #1089

wants to merge 5 commits into from

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Nov 1, 2024 •
edited
Loading

Description

Tag #1003

Checklist

  • Add tests
    • Test JSON roundtrip after Interchange.from_openmm
  • Lint
  • Update docstrings

@mattwthompson
Copy link
Member Author

Revisit this with the toolkit release after 0.16.5

@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (48a65a6) to head (e9a7d8f).

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review November 8, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yoshanuikabundi Yoshanuikabundi Awaiting requested review from Yoshanuikabundi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattwthompson