-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply getPath to PUBLIC_PATH to allow use with CDN #346
Conversation
Thanks for the pull request, @dcoa! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 1085 1086 +1
Branches 166 166
=========================================
+ Hits 1085 1086 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Hi @arbrandes, have you had time to check this small fix? C.C. @mphilbrick211 |
a160a70
to
90f8523
Compare
90f8523
to
9f031d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @dcoa. This change looks good to me ✨
Screenshots
I tried this PR and here is the before and after using your instructions to test:
@arbrandes, could you help us with a review? |
9f031d2
to
7cf788f
Compare
@CodeWithEmad, could you please have a look in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Description
When ORA is configured to be used with CDN the
locationId
is unresolved becausePUBLIC_PATH
is not fully matched.The API returns 404 because the location has
/ora-grading/
.How to replicate
ENV PUBLIC_PATH='http://apps.local.edly.io/ora-grading/'
[OPTIONAL] Proposal
I was thinking that it might be better to resolve this on the frontend platform, I mean, use
getPath
to parse the PUBLIC_PATH in the config class, in this way all the MFEs that use that variable don't need to use parse it.What do you think @arbrandes (as reviewer on the fronted platform implementation)?