Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed bug that prevents learner from seeing custom 404 #1228

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

sameeramin
Copy link
Contributor

Learners signed in with their personel accounts were not able to see the custom 404 which tells to change account (when they click on the assigned license email link)

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Before:

image

After:

image

Learners signed in with their personel accounts were not able to see the custom 404 which tells to change account (when they click on the assigned license email link)
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (e33ff83) to head (9de4713).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1228   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files         401      401           
  Lines        8583     8586    +3     
  Branches     2106     2108    +2     
=======================================
+ Hits         7596     7599    +3     
+ Misses        945      944    -1     
- Partials       42       43    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if (!enterpriseCustomer) {
if (licenseActivationRouteMatch) {
// If the user is trying to activate a license, render the license activation route.
return <Outlet />;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth writing a test case(s) for rendering of child routes via Outlet when on the license activation route to prevent future regressions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestion I've added a test

@sameeramin sameeramin merged commit 73fc10e into master Nov 28, 2024
6 checks passed
@sameeramin sameeramin deleted the sameeramin/ENT-9689 branch November 28, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants