fix: resolve recommendations query mismatch between ui and loader #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
commented
Apr 5, 2024
| return useQuery({ | ||
| ...queryCouponCodes(enterpriseCustomer.uuid), | ||
| ...queryOptionsRest, | ||
| select: (data) => { |
There was a problem hiding this comment.
Moved to service function, so the transform is shared between the UI layer and the route loader layer.
adamstankiewicz
commented
Apr 5, 2024
| @@ -26,7 +26,7 @@ const CoursePage = () => { | |||
| ]); | |||
|
|
|||
| // If there isn't an active course run we don't show the course at all | |||
| if (!courseMetadata.activeCourseRun) { | |||
| if (!courseMetadata?.activeCourseRun) { | |||
There was a problem hiding this comment.
Resolves a separate bug if you load course page with bogus course key and courseMetadata is expected to be null or undefined.
macdiesel
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/ENT-8739
(Same errors; one is minified).
For all changes
Only if submitting a visual change