-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Put Taxonomies tab behind flag #937
feat: Put Taxonomies tab behind flag #937
Conversation
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
4c4e378
to
a5006fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #937 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 612 612
Lines 10745 10746 +1
Branches 2304 2305 +1
=======================================
+ Hits 9886 9887 +1
Misses 830 830
Partials 29 29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yusuf-musleh Looks good! 👍
- I tested this: I followed the testing instructions
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
- Includes documentation
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR is a followup on #923 putting the "Taxonomies" tab behind the
taxonomiesEnabled
flag.Supporting information
Related PR:
Testing instructions
new_studio_mfe.use_new_home_page
flag is enablednew_studio_mfe.use_tagging_taxonomy_list_page
disabled initiallynew_studio_mfe.use_tagging_taxonomy_list_page
flagPrivate-ref: FAL-3699