Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Put Taxonomies tab behind flag #937

Conversation

yusuf-musleh
Copy link
Member

@yusuf-musleh yusuf-musleh commented Apr 5, 2024

Description

This PR is a followup on #923 putting the "Taxonomies" tab behind the taxonomiesEnabled flag.

Supporting information

Related PR:

Testing instructions

  1. Run this branch in your local dev stack
  2. Make sure you have the new_studio_mfe.use_new_home_page flag is enabled
  3. Make sure you have the new_studio_mfe.use_tagging_taxonomy_list_page disabled initially
  4. Navigate to the course authoring home page: http://apps.local.edly.io:2001/course-authoring/home
  5. Confirm that the taxonomies tab does not appear
  6. Now enabled the new_studio_mfe.use_tagging_taxonomy_list_page flag
  7. Confirm that the "Taxonomies" tab now appears on the home page
  8. Confirm that clicking on it navigates to the taxonomies list page

Private-ref: FAL-3699

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 5, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 5, 2024

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/put-taxonomies-tab-behind-flag branch from 4c4e378 to a5006fb Compare April 5, 2024 13:38
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (7f3164b) to head (a5006fb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         612      612           
  Lines       10745    10746    +1     
  Branches     2304     2305    +1     
=======================================
+ Hits         9886     9887    +1     
  Misses        830      830           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusuf-musleh yusuf-musleh marked this pull request as ready for review April 5, 2024 13:50
@yusuf-musleh yusuf-musleh requested a review from a team as a code owner April 5, 2024 13:50
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuf-musleh Looks good! 👍

  • I tested this: I followed the testing instructions
  • I read through the code and considered the security, stability and performance implications of the changes.
  • Includes tests for bugfixes and/or features added.
  • Includes documentation

@jesperhodge jesperhodge merged commit 50d2577 into openedx:master Apr 5, 2024
6 checks passed
@openedx-webhooks
Copy link

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the yusuf-musleh/put-taxonomies-tab-behind-flag branch April 5, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants