chore: [FC-0070] Some tests refactoring #1518
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @PKulkoRaccoonGang! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/some-tests-refactoring
branch
from
4921c69
to
b4bbfce
Compare
| @@ -114,7 +114,7 @@ describe('<AddContentContainer />', () => { | |||
| collectionId, | |||
| ); | |||
| // Mocks for ComponentEditorModal to work in tests. | |||
| jest.spyOn(editorCmsApi, 'fetchImages').mockImplementation(async () => ( // eslint-disable-next-line | |||
| jest.spyOn(editorCmsApi, 'fetchImages' as keyof typeof editorCmsApi).mockImplementation(async () => ( // eslint-disable-next-line | |||
There was a problem hiding this comment.
[inform]: The problem with the failed test is most likely related to these changes, if remove these lines the test will pass successfully
There was a problem hiding this comment.
It's fixed by this PR: #1516
It was supposed to have merged by now but there is some problem with the CLA bot.
There was a problem hiding this comment.
I merged that PR. You can remove this change now, and rebase on master instead.
There was a problem hiding this comment.
Thanks a lot!
I noticed that we have a possible related problem on the Schedule and Details page
#1516 (comment)
PKulkoRaccoonGang
requested review from
arbrandes,
bradenmacdonald and
ihor-romaniuk
PKulkoRaccoonGang
changed the title
There was a problem hiding this comment.
Thanks @PKulkoRaccoonGang, this is a very nice cleanup! 👏🏻
I noticed a few minor things that can be cleaned up further, but consider them optional.
This is conditional approval, if you remove the change to AddContentContainer.test.tsx which isn't needed anymore (rebase on master instead).
PKulkoRaccoonGang
force-pushed
the
Peter_Kulko/some-tests-refactoring
branch
from
b4bbfce
to
6890245
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1518 +/- ##
==========================================
- Coverage 93.08% 92.84% -0.24%
==========================================
Files 1049 1049
Lines 20579 20579
Branches 4445 4374 -71
==========================================
- Hits 19155 19107 -48
- Misses 1355 1405 +50
+ Partials 69 67 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Description
According to this comment, tests related to receiving waffle flags were refactored.