update: add status update on component CR's phase #1394
Conversation
- watch component resource if status.phase is updated, trigger DSC updates if component is enabled, and phase is Ready, DSC set complete (as-was) if component is enabled, but phase is notready(or anything), DSC set in-progress, notready if component is disabled, do nothing (as-was) Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -72,3 +74,11 @@ func (s *componentHandler) Init(platform cluster.Platform) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (s *componentHandler) GetStatus(ctx context.Context, cli client.Client) (components.Status, error) { | |||
| k := &componentsv1.Dashboard{} | |||
There was a problem hiding this comment.
| k := &componentsv1.Dashboard{} | |
| k := &componentsv1.Kueue{} |
There was a problem hiding this comment.
I know it's still a draft PR and not yet ready for review, but I thought it might be useful to highlight these in case you didn't catch them before making it ready 🙂
There was a problem hiding this comment.
sure, thanks!
history proves this again: do not eat and work at the same time!
| @@ -72,3 +74,10 @@ func (s *componentHandler) NewCRObject(dsc *dscv1.DataScienceCluster) client.Obj | |||
| }, | |||
| }) | |||
| } | |||
| func (s *componentHandler) GetStatus(ctx context.Context, cli client.Client) (components.Status, error) { | |||
| m := &componentsv1.Dashboard{} | |||
There was a problem hiding this comment.
| m := &componentsv1.Dashboard{} | |
| m := &componentsv1.ModelRegistry{} |
| @@ -72,3 +74,10 @@ func (s *componentHandler) Init(platform cluster.Platform) error { | |||
|
|
|||
| return nil | |||
| } | |||
| func (s *componentHandler) GetStatus(ctx context.Context, cli client.Client) (components.Status, error) { | |||
| r := &componentsv1.Dashboard{} | |||
There was a problem hiding this comment.
| r := &componentsv1.Dashboard{} | |
| r := &componentsv1.Ray{} |
| @@ -72,3 +74,10 @@ func (s *componentHandler) Init(platform cluster.Platform) error { | |||
|
|
|||
| return nil | |||
| } | |||
| func (s *componentHandler) GetStatus(ctx context.Context, cli client.Client) (components.Status, error) { | |||
| t := &componentsv1.Dashboard{} | |||
There was a problem hiding this comment.
| t := &componentsv1.Dashboard{} | |
| t := &componentsv1.TrainingOperator{} |
| @@ -79,3 +81,10 @@ func (s *componentHandler) Init(platform cluster.Platform) error { | |||
|
|
|||
| return nil | |||
| } | |||
| func (s *componentHandler) GetStatus(ctx context.Context, cli client.Client) (components.Status, error) { | |||
| t := &componentsv1.Dashboard{} | |||
There was a problem hiding this comment.
| t := &componentsv1.Dashboard{} | |
| t := &componentsv1.TrustyAI{} |
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria