Makefile: make USE_LOCAL overridable #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykaliuta
force-pushed
the
makefile-use-local
branch
from
1e10f2a
to
0a6c463
Compare
zdtsw
reviewed
Nov 19, 2024
ykaliuta
force-pushed
the
makefile-use-local
branch
from
0a6c463
to
c1a02d0
Compare
Sure. Updated. |
zdtsw
approved these changes
Nov 19, 2024
ykaliuta
force-pushed
the
makefile-use-local
branch
from
c1a02d0
to
d31701e
Compare
Get USE_LOCAL image build flag from makefile variable to make it overridable with `make USE_LOCAL=true image` Do not allow to get its value for environment be default due to pretty generic name. This is shorter than the old recommendation of overriding IMAGE_BUILD_FLAGS. And since now CGO_ENABLED is also a flag, does not mess up with it. * USE_LOCAL=true uses existing manifests from opt/manifests for the produced image without downloading them with get_all_manifests.sh making it possible to both save time and make local amendments. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
ykaliuta
force-pushed
the
makefile-use-local
branch
from
d31701e
to
bd1fa1e
Compare
|
@zdtsw sorry, updated the message and removed the ACK :( |
zdtsw
approved these changes
Nov 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## incubation #1384 +/- ##
=============================================
Coverage ? 18.91%
=============================================
Files ? 30
Lines ? 3399
Branches ? 0
=============================================
Hits ? 643
Misses ? 2687
Partials ? 69 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
openshift-merge-bot
bot
merged commit cea41dc
into
opendatahub-io:incubation
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get USE_LOCAL image build flag from makefile variable to make it overridable with
make USE_LOCAL=true imageDo not allow to get its value for environment be default due to pretty generic name.
This is shorter than the old recommendation of overriding IMAGE_BUILD_FLAGS. And since now CGO_ENABLED is also a flag, does not mess up with it.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria