Dockerfile, Makefile: make CGO_ENABLED configurable

[ykaliuta]

The commit
a107703 ("feat(fips): enable GO_ENABLED in build (#1001)")

enabled CGO which makes problems for builders on non-x86 platforms.

Make it as an in the Dockerfile keeping default the same (enabled),
but make it possible to override with either environment
(export CGO_ENABLED=0) or make (make CGO_ENABLED=0 image-build)

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[ykaliuta]

/cc @zdtsw

[ykaliuta]

/cc @jackdelahunt

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asanzgom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [asanzgom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grdryn]

Given that this has been enabled for a long time, and there are FIPS-related implications (not sure how much we care about those right now), I wonder if maybe it would be preferable to have a build arg for it that defaults to enabled, but can easily be set by the person building it to turn it off?

[ykaliuta]

Given that this has been enabled for a long time, and there are FIPS-related implications (not sure how much we care about those right now), I wonder if maybe it would be preferable to have a build arg for it that defaults to enabled, but can easily be set by the person building it to turn it off?

I'm wondering what the implications are if it is not used in CI but for local builds only AFAIK.

[zdtsw]

Given that this has been enabled for a long time, and there are FIPS-related implications (not sure how much we care about those right now), I wonder if maybe it would be preferable to have a build arg for it that defaults to enabled, but can easily be set by the person building it to turn it off?

preferably, to add support : switch on and off with args.
but i do not have strong opinion it has to be done in that way, unless we have requirement to make ODH fips, as for downstream it is up to a different build system

[ykaliuta]

Implemented

[grdryn]

/lgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (incubation@77b6db8). Learn more about missing BASE report.

Additional details and impacted files

@@              Coverage Diff              @@
##             incubation    #1382   +/-   ##
=============================================
  Coverage              ?   18.91%           
=============================================
  Files                 ?       30           
  Lines                 ?     3399           
  Branches              ?        0           
=============================================
  Hits                  ?      643           
  Misses                ?     2687           
  Partials              ?       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests