Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: explicitly add auth config in DSCI #1368

Open
wants to merge 1 commit into
base: incubation
Choose a base branch
from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Nov 12, 2024

seems users who are using their own way to setup ODH encountered some issue in the past,
this is only to be more clear and update our sample config for DSCI to migitate missing config.
without speicify authspec, DSCI should have it auto set during creation

side note:
one way we could try is to add check on webhook for DSCI.
i will need to think about more in another PR if required

Description

related but not for fix: https://issues.redhat.com/browse/RHOAIENG-15630

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw changed the title update: explicity add auth config in DSCI update: explicitly add auth config in DSCI Nov 12, 2024
@zdtsw zdtsw removed the request for review from grdryn November 12, 2024 10:46
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (incubation@e25487a). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             incubation    #1368   +/-   ##
=============================================
  Coverage              ?   18.96%           
=============================================
  Files                 ?       30           
  Lines                 ?     3390           
  Branches              ?        0           
=============================================
  Hits                  ?      643           
  Misses                ?     2678           
  Partials              ?       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@lphiri lphiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zdtsw whats the impact of this change (if any) on #947?

@zdtsw
Copy link
Member Author

zdtsw commented Nov 12, 2024

@zdtsw whats the impact of this change (if any) on #947?

this one only updated the sample in CSV when user created DSCI it should show AuthSPec also the README
No directly impact to mentioned 947

@zdtsw zdtsw added the odh-2.21 label Nov 13, 2024
@zdtsw zdtsw force-pushed the chore_140 branch 2 times, most recently from 387c65d to 67676b0 Compare November 13, 2024 09:54
@lphiri
Copy link

lphiri commented Nov 13, 2024

@zdtsw whats the impact of this change (if any) on #947?

this one only updated the sample in CSV when user created DSCI it should show AuthSPec also the README No directly impact to mentioned 947

I see. I inverted my question:) The point of the question was whether users will still need to manually configure anything once the other MR is merged, in which case there is no need to add the sample. But now I see the MR still leaves the option for users to manually configure the audience.

@zdtsw
Copy link
Member Author

zdtsw commented Nov 13, 2024

@zdtsw whats the impact of this change (if any) on #947?

this one only updated the sample in CSV when user created DSCI it should show AuthSPec also the README No directly impact to mentioned 947

I see. I inverted my question:) The point of the question was whether users will still need to manually configure anything once the other MR is merged, in which case there is no need to add the sample. But now I see the MR still leaves the option for users to manually configure the audience.

yeah, i think these 2 PR serve differen purpose.
this one only as a good reference in case user who might copy-paste from it into their yaml file stored in GitOps.
if so, even the auto created DSCI should have these value, after "patch" from yaml, these will get lost.

@zdtsw
Copy link
Member Author

zdtsw commented Nov 15, 2024

put on-hold, lets wait for 947 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants