-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: explicitly add auth config in DSCI #1368
base: incubation
Are you sure you want to change the base?
Conversation
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## incubation #1368 +/- ##
=============================================
Coverage ? 18.96%
=============================================
Files ? 30
Lines ? 3390
Branches ? 0
=============================================
Hits ? 643
Misses ? 2678
Partials ? 69 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
387c65d
to
67676b0
Compare
I see. I inverted my question:) The point of the question was whether users will still need to manually configure anything once the other MR is merged, in which case there is no need to add the sample. But now I see the MR still leaves the option for users to manually configure the audience. |
yeah, i think these 2 PR serve differen purpose. |
put on-hold, lets wait for 947 first |
seems users who are using their own way to setup ODH encountered some issue in the past,
this is only to be more clear and update our sample config for DSCI to migitate missing config.
without speicify authspec, DSCI should have it auto set during creation
side note:
one way we could try is to add check on webhook for DSCI.
i will need to think about more in another PR if required
Description
related but not for fix: https://issues.redhat.com/browse/RHOAIENG-15630
How Has This Been Tested?
Screenshot or short clip
Merge criteria