Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: reconcile components in parallel #1219

Open
wants to merge 6 commits into
base: incubation
Choose a base branch
from

Conversation

ykaliuta
Copy link
Contributor

@ykaliuta ykaliuta commented Sep 4, 2024

This is just an RFC.

There is a lot of independent work in component's reconciliation procedures which could run in parallel.
One of the reasons is that with the latest "wait for deployment ready" change initial setup takes much longer time.

The code is not thread-safe. I tried to address obvious issues:

  1. unsafe Client (make a wrapper)
  2. unsafe prometheus config update

With UpdateWithRetry updating DSC should be fine.

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ykaliuta. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ykaliuta
Copy link
Contributor Author

ykaliuta commented Sep 4, 2024

/cc @zdtsw @bartoszmajsak

@ykaliuta
Copy link
Contributor Author

ykaliuta commented Sep 4, 2024

/cc @lburgazzoli

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants