Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NIM flag logic #312

Open
wants to merge 17 commits into
base: incubating
Choose a base branch
from
Open

Add NIM flag logic #312

wants to merge 17 commits into from

Conversation

trujillm
Copy link

Add NIM flag logic

Description

This will get the nim flag state of removed or managed from params.env and add to the environment variables for odh-model-controller to be utilize

How Has This Been Tested?

Unit tests

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

hdefazio and others added 16 commits October 25, 2024 16:56
@hdefazio
Restore fixed versions in params.env
56ae3b4
@vaibhavjainwiz
Add runtime template of vLLM ROCM (opendatahub-io#287)
828da6b 
Signed-off-by: Vaibhav Jain <vajain@redhat.com>
@vaibhavjainwiz
Add runtime template of vLLM Gaudi (opendatahub-io#290)
479aece 
Signed-off-by: Vaibhav Jain <vajain@redhat.com>
@Jooho
[Cherry-Pick] vLLM multi-node template (opendatahub-io#292)
36ca97c 
* [RHOAIENG-15386] add a new servingruntime vllm-multinode-template (opendatahub-io#284)

* add a new servingruntime vllm-multinode-template

Signed-off-by: jooho lee <jlee@redhat.com>

* follow up comments

Signed-off-by: jooho lee <jlee@redhat.com>

* follow up comments

Signed-off-by: jooho lee <jlee@redhat.com>

* follow up comments

Signed-off-by: jooho lee <jlee@redhat.com>

* follow up comments

Signed-off-by: jooho lee <jlee@redhat.com>

---------

Signed-off-by: jooho lee <jlee@redhat.com>

* Fix ServingRuntime args (opendatahub-io#291)

* fix runtime args

Signed-off-by: jooho lee <jlee@redhat.com>

* add disable_custom_all_reduce solving vllm-8735 issue

Signed-off-by: jooho lee <jlee@redhat.com>

---------

Signed-off-by: jooho lee <jlee@redhat.com>

---------

Signed-off-by: jooho lee <jlee@redhat.com>
@Jooho
enhance probe to support rollingUpgrade (opendatahub-io#293)
37badd7 
Signed-off-by: jooho lee <jlee@redhat.com>
@Jooho
Merge pull request opendatahub-io#294 from Jooho/cp_15763
898ebab 
[Cherry-Pick] Enhance probe to support rollingUpgrade (opendatahub-io#293)
@Jooho
enhance template not to use query for checking model health
e9a51d1 
Signed-off-by: jooho lee <jlee@redhat.com>
@Jooho
Merge pull request opendatahub-io#296 from Jooho/cp_vllm_final
44e33d6 
[Cherry-pick] enhance template not to use query for checking model health
@Jooho
fix typo
5a70abd 
Signed-off-by: jooho lee <jlee@redhat.com>
@Jooho
Merge pull request opendatahub-io#298 from Jooho/fix_typo
107a36a 
[cherry-pick] fix typo
@rpancham
Update caikit-tgis and ovms stable image (opendatahub-io#299)
c3b17b8 
Signed-off-by: rpancham <rpancham@redhat.com>
@israel-hdez
Pin vLLM images for Gaudi and ROCM
28d1d83 
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
@israel-hdez
Merge branch 'main' into 0120-sync
fc8fde8 
Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
@israel-hdez
Merge pull request opendatahub-io#302 from israel-hdez/0120-sync
8a19341 
Sync main -> release-0.12.0: Preparing ODH release
@Jooho
update global ca bundle logic and storage-config logic to follow up o…
b5de317 
…dh operator pr(1339) (opendatahub-io#308)

Signed-off-by: jooho lee <jlee@redhat.com>
@Jooho
Merge pull request opendatahub-io#309 from Jooho/cp_RHOAIENG-16070
516e192 
[Cherry-Pick] update global ca bundle logic and storage-config logic
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

Hi @trujillm. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@trujillm
Add NIM flag logic
0e9e122 
Signed-off-by: mtrujillo <trujillo169@hotmail.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti, trujillm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@trujillm
Copy link
Author

@spolti do you know if I need to change something for the image tag failure?

israel-hdez
israel-hdez requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the target branch to incubating.
The main branch is now a stable/downstream branch.

@Jooho Jooho changed the base branch from main to incubating November 26, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolti spolti spolti approved these changes

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

@israel-hdez israel-hdez Awaiting requested review from israel-hdez

Assignees
No one assigned
Labels
approved needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trujillm @spolti @israel-hdez @hdefazio @vaibhavjainwiz @Jooho @rpancham