Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(nbcs): update tooling in controller's Makefiles - kubernetes and kustomize #432

Merged
merged 2 commits into from
Nov 8, 2024

Commits on Nov 8, 2024

  1. [Test] Update the k8s tool used for the test execution

    The version 1.23 is no longer supported [1] and only releases from
    1.28 - 1.31 versions are supported. Based on the [2], the
    OpenShift 4.13 (oldest we care about right now) is based on Kubernetes
    in version 1.26, so let's allign to that version.
    
    * [1] https://kubernetes.io/releases/
    * [2] https://access.redhat.com/solutions/4870701
    jstourac committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0f3c742 View commit details
    Browse the repository at this point in the history
  2. [Fix] kustomize package version revision

    This is a followup of opendatahub-io#391 (1b2dd4f).
    
    Without this, we can see the following failure during the e2e tests
    execution:
    ```
    make run-ci-e2e-tests
    ...
    GOBIN=/home/jstourac/workspace/rhosai/odh/kubeflow/components/odh-notebook-controller/bin go install sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2
    go: sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2: sigs.k8s.io/kustomize/v3/cmd/kustomize@v5.0.2: invalid version: unknown revision v3/cmd/kustomize/v5.0.2
    make[1]: *** [Makefile:243: kustomize] Error 1
    ...
    ```
    This caused that all e2e tests failed. After this fix, some e2e tests
    pass. The other seem to fail on a problem unrelated to this one.
    jstourac committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8dba731 View commit details
    Browse the repository at this point in the history