Update kfto test support disconnected #283
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ChughShilpa
reviewed
Nov 26, 2024
| @@ -31,7 +31,7 @@ import ( | |||
| ) | |||
|
|
|||
| func TestPyTorchJobWithCuda(t *testing.T) { | |||
| runKFTOPyTorchJob(t, GetCudaTrainingImage(), "nvidia.com/gpu", 1) | |||
| runKFTOPyTorchJob(t, GetCudaTrainingImage(), "nvidia.com/gpu", 0) | |||
There was a problem hiding this comment.
Why you have set numGpus to 0?
There was a problem hiding this comment.
Ahh, my mistake..
Thank you Shilpa for pointing that out !!
abhijeet-dhumal
force-pushed
the
update-kfto-test-support-disconnected
branch
from
c45a274
to
1553b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RHOAIENG-16198
It basically downloads the alpaca-dataset from s3/minio and load it using load_from_disk method :
How Has This Been Tested?
Same python script tested locally :
Merge criteria: