refact: rewrite some files in ts

package.json

@@ -67,6 +67,8 @@
   "devDependencies": {
     "@babel/cli": "^7.23.4",
     "@graphql-eslint/eslint-plugin": "^3.20.1",
+    "@types/express": "^5.0.0",
+    "@types/lodash": "^4.17.9",
     "@typescript-eslint/eslint-plugin": "^7.10.0",
     "@typescript-eslint/parser": "^7.10.0",
     "commitizen": "^4.3.0",

src/server/controllers/account-transactions.js → src/server/controllers/account-transactions.ts

@@ -1,4 +1,5 @@
 import { Parser } from '@json2csv/plainjs';
+import type { RequestHandler } from 'express';
 import gqlV2 from 'graphql-tag';
 import { difference, get, head, intersection, isNil, pick, toUpper, trim } from 'lodash';
 import moment from 'moment';
@@ -454,16 +455,21 @@ const applyMapping = (mapping, row) => {
   return res;
 };
 
-/**
- * @param {import('express').Request} req
- * @param {import('express').Response} res
- */
-const accountTransactions = async (req, res) => {
+type Params = {
+  slug: string;
+  reportType: 'hostTransactions' | 'transactions';
+  type?: 'credit' | 'debit';
+  kind?: string;
+  format: 'json' | 'csv' | 'txt';
+};
+
+const accountTransactions: RequestHandler<Params> = async (req, res) => {
   if (!['HEAD', 'GET'].includes(req.method)) {
-    return res.status(405).send({ error: { message: 'Method not allowed' } });
+    res.status(405).send({ error: { message: 'Method not allowed' } });
+    return;
   }
 
-  const variables = pick({ ...req.params, ...req.query }, [
+  const variables: any = pick({ ...req.params, ...req.query }, [
     'account',
     'accountingCategory',
     'dateFrom',
@@ -627,18 +633,18 @@ const accountTransactions = async (req, res) => {
     variables.fullDescription = req.params.reportType === 'hostTransactions' ? true : false;
   }
 
-  let fields = get(req.query, 'fields', '')
+  let fields = (get(req.query, 'fields', '') as string)
     .split(',')
     .map(trim)
     .filter((v) => !!v);
 
   if (fields.length === 0) {
-    const remove = get(req.query, 'remove', '')
+    const remove = (get(req.query, 'remove', '') as string)
       .split(',')
       .map(trim)
       .filter((v) => !!v);
 
-    const add = get(req.query, 'add', '')
+    const add = (get(req.query, 'add', '') as string)
       .split(',')
       .map(trim)
       .filter((v) => !!v);
@@ -714,7 +720,8 @@ const accountTransactions = async (req, res) => {
         res.append('Access-Control-Expose-Headers', 'X-Exported-Rows');
         res.append('X-Exported-Rows', result.transactions.totalCount);
         if (req.method === 'HEAD') {
-          return res.status(200).end();
+          res.status(200).end();
+          return;
         }
 
         if (result.transactions.totalCount === 0) {
@@ -725,7 +732,7 @@ const accountTransactions = async (req, res) => {
         const mapping = pick(csvMapping, fields);
 
         const mappedTransactions = result.transactions.nodes.map((t) => applyMapping(mapping, t));
-        res.write(json2csv(mappedTransactions));
+        res.write(json2csv(mappedTransactions, {}));
         res.write(`\n`);
 
         if (result.transactions.totalCount > result.transactions.limit) {

src/server/routes.js → src/server/routes.ts

@@ -1,4 +1,5 @@
 import cors from 'cors';
+import type { Express } from 'express';
 
 import { idOrUuid } from './lib/utils';
 import controllers from './controllers';
@@ -8,7 +9,7 @@ const requireApiKey = (req, res, next) => {
   next();
 };
 
-export const loadRoutes = (app) => {
+export const loadRoutes = (app: Express) => {
   app.use(cors());
 
   app.get('/', (req, res) => {