-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken test for utils.solver with symengine #1340
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #1340 +/- ##
==========================================
+ Coverage 83.85% 83.94% +0.09%
==========================================
Files 66 66
Lines 5499 5499
Branches 1257 1257
==========================================
+ Hits 4611 4616 +5
+ Misses 572 567 -5
Partials 316 316 ☔ View full report in Codecov by Sentry. |
Only affects symengine, apparently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. I would at least change it to
fix_constraint = m.constraints[-1]
and then perform assertions on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
1a8f80c
to
f5b8059
Compare
Minor change that repairs a broken test. Also, the logic of the test was a bit off and has now been corrected.