Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken test for utils.solver with symengine #1340

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

cdiener
Copy link
Member

@cdiener cdiener commented Jul 5, 2023

  • fix failing test on newer sympy versions
  • description of feature/fix
  • tests added/passed
  • add an entry to the next release

Minor change that repairs a broken test. Also, the logic of the test was a bit off and has now been corrected.

@cdiener cdiener changed the title Fix/fix objective test Fix broken test for utils.solver Jul 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09% 🎉

Comparison is base (e48bc84) 83.85% compared to head (19ba0fc) 83.94%.

❗ Current head 19ba0fc differs from pull request most recent head f5b8059. Consider uploading reports for the commit f5b8059 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1340      +/-   ##
==========================================
+ Coverage   83.85%   83.94%   +0.09%     
==========================================
  Files          66       66              
  Lines        5499     5499              
  Branches     1257     1257              
==========================================
+ Hits         4611     4616       +5     
+ Misses        572      567       -5     
  Partials      316      316              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdiener cdiener mentioned this pull request Jul 5, 2023
6 tasks
@cdiener
Copy link
Member Author

cdiener commented Jul 7, 2023

Only affects symengine, apparently.

@cdiener cdiener changed the title Fix broken test for utils.solver Fix broken test for utils.solver with symengine Jul 7, 2023
Copy link
Member

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. I would at least change it to

fix_constraint = m.constraints[-1]

and then perform assertions on that.

tests/test_util/test_solver.py Outdated Show resolved Hide resolved
tests/test_util/test_solver.py Outdated Show resolved Hide resolved
Copy link
Member

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@cdiener cdiener merged commit 9e48208 into opencobra:devel Sep 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants