Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobrapy Package Family Tree Poster #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cobrapy Package Family Tree Poster #16

wants to merge 2 commits into from

Conversation

ChristianLieven
Copy link

@ChristianLieven ChristianLieven commented Oct 22, 2018

@Midnighter asked me to digitalize and share the poster I made for cobrapy for the COBRA2018 conference.

Frankly I don't know if this is a good spot for it. I tried properly embedding it such that all the links in the SVG are clickable, but I know too little HUGO to make it work. @cdiener, do you think this is something that could go on the homepage? I'm happy to modify it too.

Cheers,

Christian

@cdiener
Copy link
Member

cdiener commented Oct 23, 2018

Cool thanks. Maybe @Midnighter could comment where he wanted that on the page. It might be a bit big on the front page. We could have its own contributor page for that or whatever you propose. I have never succeeded in making links within SVGs work with any browser. They sometimes work in the PDF export but that is pure gambling. I think a rendered version with a link to the packages section might be enough 🤔

@ChristianLieven
Copy link
Author

ChristianLieven commented Oct 23, 2018

If you check out the branch and then open up the image in a dedicated tab the links all work. I think it is a matter of embedding the actual SVG into the HTML inline for this to function. Akin to what is described here: https://discourse.gohugo.io/t/embedding-inline-svg-in-content-markdown/7511

Alas, I was unable to get the shortcodes trick to work, and thus reverted to simply using a figure referencing the svg. I guess if we put it somewhere else it can live in its own template inline with the template html or as a partial, which could make it work with less voodoo.

@Midnighter
Copy link
Member

I have no clear idea of where this should live. Many people seem to miss the packages page, though, so I don't really mind something "in your face".

@cdiener
Copy link
Member

cdiener commented Oct 23, 2018

@ChristianLieven that is cool! In that case SVG seems the way to go. Do you think there is a way to reduce file size a bit? I think most of that comes from the vector tree in the background. Maybe simplifying the paths could help... I think we can make the embedding work. Since the intro template is only used for that page I don't see a problem with hardcoding the image there (like in the linked forum discussion).

@Midnighter In that case the homepage might be a good option. It appears after all the description so I guess its fine.

@ChristianLieven
Copy link
Author

ChristianLieven commented Oct 24, 2018

Maybe simplifying the paths could help...

I can give that a go. I can probably remove the title too (as it would be redundant with the hero banner on the main page anyways). There are also many 'invisible' edges and duplicate panels that I could merge into a single entity which should simplify the figure a lot!

Moritz and I were also toying with the idea of abstracting the SVG into a simple shape that has some js magic on top that fills out the respective branches of the tree automagically. This is just a future idea I'd wanted to capture so nothing that'll be ready soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants