Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove xpath useless method #976

Merged
merged 5 commits into from
May 22, 2024
Merged

Conversation

codeskyblue
Copy link
Member

@codeskyblue codeskyblue commented May 17, 2024

  • add RPCStackOverflowError
  • remove useless code, fix find_last_match

support new usage

(d.xpath("App") | d.xpath("NFC")).click()

(d.xpath("//android.widget.TextView") & d.xpath("App")).click()

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 55.44041% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 24.87%. Comparing base (64c6f2b) to head (32437ef).

Files Patch % Lines
uiautomator2/xpath.py 63.30% 42 Missing and 9 partials ⚠️
uiautomator2/core.py 20.00% 16 Missing ⚠️
uiautomator2/utils.py 8.33% 11 Missing ⚠️
uiautomator2/__init__.py 33.33% 4 Missing ⚠️
uiautomator2/watcher.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   24.39%   24.87%   +0.47%     
==========================================
  Files          19       19              
  Lines        2820     2802      -18     
  Branches      430      429       -1     
==========================================
+ Hits          688      697       +9     
+ Misses       2106     2080      -26     
+ Partials       26       25       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeskyblue codeskyblue merged commit 82ef1f9 into master May 22, 2024
8 checks passed
@codeskyblue codeskyblue deleted the remove_xpath_useless_method branch May 22, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant