Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix solis #1989

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix solis #1989

merged 1 commit into from
Nov 6, 2024

Conversation

LKuemmel
Copy link
Contributor

@LKuemmel LKuemmel commented Nov 1, 2024

@LKuemmel LKuemmel requested a review from ndrsnhs November 1, 2024 08:10
@the2masters
Copy link
Contributor

Leider funktioniert das immer noch nicht, weil die Variablen unterhalb des if/elif nicht mehr sichtbar sind.
inverter.py:
<class 'UnboundLocalError'> ("local variable 'power' referenced before assignment",)
counter.py:
<class 'UnboundLocalError'> ("local variable 'register_offset' referenced before assignment",)

Ich habe mir das heute auch einmal angesehen und folgenden Fix errstellt: #1990
Aber Achtung: Ich habe Python nie gelernt, ich habe den Quelltext solange angepasst bis es lief ;-)
Ob wir deinen‌ Fix auch brauchen weiß ich nicht, ich habe keine älteren Wechselrichter um es auszuprobieren.

@the2masters the2masters mentioned this pull request Nov 1, 2024
Merged
@LKuemmel LKuemmel merged commit 14ac8f3 into openWB:master Nov 6, 2024
1 check passed
@LKuemmel LKuemmel deleted the fixes branch November 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndrsnhs ndrsnhs ndrsnhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LKuemmel @the2masters @ndrsnhs