fix: Ruby 3.0 compatibility for generate_r (#1538)

* fix: Ruby 3.0 compatibility for generate_r * Actually test the sdk_experimental gem in CI * dir name doesn't match gemspec name
open-telemetry · Nov 2, 2023 · 39a7e7f · 39a7e7f
1 parent 6457553
commit 39a7e7f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -21,6 +21,7 @@ jobs:
           - opentelemetry-metrics-api
           - opentelemetry-registry
           - opentelemetry-sdk
+          - opentelemetry-sdk-experimental
           - opentelemetry-semantic_conventions
           - opentelemetry-test-helpers
         os:

diff --git a/sdk_experimental/lib/opentelemetry/sdk/trace/samplers/consistent_probability_tracestate.rb b/sdk_experimental/lib/opentelemetry/sdk/trace/samplers/consistent_probability_tracestate.rb
@@ -106,7 +106,7 @@ def decimal(str)
           end
 
           def generate_r(trace_id)
-            x = trace_id.unpack1('Q>', offset: 8) | 0x3
+            x = trace_id.unpack1('@8Q>') | 0x3
             64 - x.bit_length
           end
         end