-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add grpc support for log export #6340
Merged
dmathieu
merged 5 commits into
open-telemetry:main
from
codeboten:codeboten/add-grpc-support-for-log-export
Nov 19, 2024
Merged
add grpc support for log export #6340
dmathieu
merged 5 commits into
open-telemetry:main
from
codeboten:codeboten/add-grpc-support-for-log-export
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for grpc export for the logging signal in the config package. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/add-grpc-support-for-log-export
branch
from
November 18, 2024 15:51
e924bd3
to
2f0f28c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6340 +/- ##
=====================================
Coverage 66.8% 66.9%
=====================================
Files 193 193
Lines 15620 15652 +32
=====================================
+ Hits 10448 10479 +31
- Misses 4881 4882 +1
Partials 291 291
|
MrAlias
approved these changes
Nov 18, 2024
dmathieu
approved these changes
Nov 18, 2024
@codeboten it looks like the white-space formatting needs to be updated to fix the lint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for grpc export for the logging signal in the config package.
Leaving this in draft until #6338 is merged and i'll rebase.